This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Store e2e command output /w errors + remove variable sleep #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the test output much more readable. Errors are nested with their command args.
It also allows you to read parallel output.
I haven't enabled parallel, because vm run appears to have a bug using dmsetup in parallel.
Successful commands no longer output to stdout, but we could add a gate for this if desired.
I removed the variable sleep because it appears to have less impact on the docker-bridge behavior in #423 than I previously observed.